Matthias Clasen [Wed, 20 Mar 2013 22:17:00 +0000 (18:17 -0400)]
New visibility handling in gtk
Matthias Clasen [Fri, 15 Mar 2013 10:35:30 +0000 (06:35 -0400)]
New visibility handling in gdk
Change the visibility handling to be the same way we do it in
GLib now. We pass -fvisibility=hidden to gcc and decorate public
functions with __attribute__((visibility("default"))).
This commit just does this for GDK, GTK+ will follow later.
Matthias Clasen [Sun, 5 May 2013 14:31:08 +0000 (10:31 -0400)]
Ignore deprecations where needed
There are a few places where we are still using deprecated
API internally - ignore deprecations around these uses.
Matthias Clasen [Sun, 5 May 2013 14:28:54 +0000 (10:28 -0400)]
Fix up headerless symbols
Some symbols are exported from GTK+, but do not appear in any
headers. For these, use _GDK_EXTERN in the source file to make
sure they are exported.
Matthias Clasen [Sun, 5 May 2013 18:24:55 +0000 (14:24 -0400)]
Add annotations in a11y headers
Matthias Clasen [Wed, 20 Mar 2013 22:17:32 +0000 (18:17 -0400)]
Add annotations to gtk headers
Add annotations to all exported functions in GTK+ headers.
Matthias Clasen [Wed, 20 Mar 2013 18:38:59 +0000 (14:38 -0400)]
gtk: Use GDK_AVAILABLE_IN_ALL for generated enum types
glib-mkenums is not currently clever enough to know which version an
enum type was added in, so just mark all the _get_type() functions as
available in all versions.
Matthias Clasen [Sun, 5 May 2013 15:32:20 +0000 (11:32 -0400)]
Just ignore deprecations inside deprecated/
Not worth tracking uses of deprecated API individually here.
Matthias Clasen [Fri, 15 Mar 2013 12:30:23 +0000 (08:30 -0400)]
Use _GDK_EXTERN when defining the decorators
Make all GDK_DEPRECATED and GDK_AVAILABLE macros use a
new _GDK_EXTERN macro. _GDK_EXTERN defaults to just 'extern'
but a subsequent commit will add visibility handling to it
while building GTK+.
Matthias Clasen [Fri, 15 Mar 2013 09:58:39 +0000 (05:58 -0400)]
Add GDK_AVAILABLE_IN_ALL annotations in gdk
This is in preparation to modernizing our handing
of exported symbols.
Matthias Clasen [Fri, 15 Mar 2013 10:50:34 +0000 (06:50 -0400)]
Use GDK_AVAILABLE_IN_ALL for generated enum types
glib-mkenums is not currently clever enough to know which version an
enum type was added in, so just mark all the _get_type() functions as
available in all versions.
Matthias Clasen [Fri, 15 Mar 2013 01:22:22 +0000 (21:22 -0400)]
gdkversionmacros.h: add GDK_AVAILABLE_IN_ALL
Add a macro to declare that a particular symbol is available in all
versions of GTK+.
All newly-added symbols should have proper version macros (like
GDK_AVAILABLE_IN_3_4).
Matthias Clasen [Sun, 5 May 2013 16:16:51 +0000 (12:16 -0400)]
gtk-demo: Include config.h first
If config.h is included after gdkversionmacros.h, _GDK_EXTERN
gets redefined and cpp doesn't like that.
Matthias Clasen [Sun, 5 May 2013 16:16:16 +0000 (12:16 -0400)]
gtk-demo: Don't include config.h needlessly
It is not needed here.
Matthias Clasen [Sun, 5 May 2013 18:26:33 +0000 (14:26 -0400)]
Remove an unused private function
_gtk_text_layout_get_line_xrange was not exported and not used
inside GTK+ either.
Victor Ibragimov [Sun, 5 May 2013 14:22:27 +0000 (19:22 +0500)]
Updated Tajik Translation
Matthias Clasen [Sat, 4 May 2013 23:21:56 +0000 (19:21 -0400)]
Always use gint for border_width
This avoids an evil trap when doing MAX (..., ... - 2 * border_width)
and the expression on the right gets promoted to unsigned, instead
of going negative as you would expect.
https://bugzilla.gnome.org/show_bug.cgi?id=699633
Ignacio Casal Quinteiro [Sat, 4 May 2013 20:51:37 +0000 (22:51 +0200)]
window: handle titlebar property for the buildable interface
Matthias Clasen [Sun, 28 Apr 2013 21:50:01 +0000 (17:50 -0400)]
Some window size test tweaks
Draw a checkerboard pattern, and add an interactive mode that
waits for events before moving on. This makes it easier to see
when a size is wrong.
Matthias Clasen [Sat, 27 Apr 2013 22:01:19 +0000 (18:01 -0400)]
Add some more GtkWindow tests
These tests check that a toplevel window ends up with the expected
size after setting default sizes or resizing. It currently passes
on X, but fails with client-side decorations under X and Wayland.
Matthias Clasen [Sat, 4 May 2013 20:11:00 +0000 (16:11 -0400)]
Prevent criticals when initializing a Wayland display
When we call _gdk_wayland_display_load_cursor_theme during
the initial opening of the first display, gdk_setting_get does
not work yet, since it relies on the default display/screen
being set, which only happens after open returns.
Instead, just use the screen of this display.
Matthias Clasen [Sat, 4 May 2013 02:29:20 +0000 (22:29 -0400)]
Fix setting child properties
This was broken in
e9f182e37a7f6e2dc339054841a3c9f930f573ed
Matthias Clasen [Sat, 4 May 2013 00:03:12 +0000 (20:03 -0400)]
Don't clear data on a NULL screen
This makes GtkSettings survive the object finalize test.
John Ralls [Fri, 3 May 2013 23:41:49 +0000 (16:41 -0700)]
Bug 606378 - gdk doesn't handle non-main thread rendering on Quartz
Document that the restrictions on Win32 apply also to Quartz.
Stefan Sauer [Fri, 3 May 2013 18:39:24 +0000 (20:39 +0200)]
widget: fix two typos in api-docs
Colin Walters [Thu, 2 May 2013 22:32:07 +0000 (18:32 -0400)]
reftests: Don't use spaces in Makefile first line
Otherwise Emacs makes one's life miserable.
Guillaume Desmottes [Thu, 25 Apr 2013 14:30:12 +0000 (16:30 +0200)]
treemodelsort: destroy the root only if we are removing the latest row of the level
GtkIconView doesn't ref the rows of the model so we have to make sure that a
level is actually empty before destroying it.
https://bugzilla.gnome.org/show_bug.cgi?id=698846
Matthias Clasen [Fri, 3 May 2013 01:36:45 +0000 (21:36 -0400)]
Make it possible to finalize theming engines
This was broken since forever. Good that we never finalize
theme engines...
Matthias Clasen [Fri, 3 May 2013 00:43:34 +0000 (20:43 -0400)]
GtkInvisible behaves like GtkWindow
As far as refcounting is concerned, invisibles are like
windows: you have to destroy them.
Matthias Clasen [Fri, 3 May 2013 00:42:24 +0000 (20:42 -0400)]
Only check for finalization after a grace period
This makes the file chooser pass this test
Matthias Clasen [Fri, 3 May 2013 00:00:49 +0000 (20:00 -0400)]
Prevent a segfault if GtkAppChooserDialog gets disposed early
If the async call is finished after the dialog is already disposed,
bad things happen. Prevent that by marking the dialog as dismissed
in this case.
Benjamin Otte [Thu, 2 May 2013 14:27:47 +0000 (16:27 +0200)]
gdk: Remove new gdk_display_manager_peek() API
It's not necessary anymore because gdk_display_manager_get() always
succeeds and the value is independant of when it was called as it's no
longer backend specific.
Benjamin Otte [Thu, 2 May 2013 14:26:37 +0000 (16:26 +0200)]
window: Handle attach widget disappearing without weak pointers
Fixes the window not emitting a "notify::attached-to" signal when the
attach-widget goes away.
Benjamin Otte [Thu, 2 May 2013 14:17:30 +0000 (16:17 +0200)]
displaymanager: Remove GInitable implementation
This is not needed anymore, as only one type exists and that type can
always be instantiated.
Benjamin Otte [Thu, 2 May 2013 14:15:02 +0000 (16:15 +0200)]
broadway: Remove displaymanager implementation
This is an API break, but the broadway backend is unsupported, so we can
get away with it.
Benjamin Otte [Thu, 2 May 2013 14:12:53 +0000 (16:12 +0200)]
wayland: Remove displaymanager implementation
This is an API break, but the wayland backend is unsupported, so we can
get away with it.
Benjamin Otte [Thu, 2 May 2013 14:09:09 +0000 (16:09 +0200)]
displaymanager: Don't create backend-specific display managers
Just create a backend-agnostic displaymanager. Creating the displays
later on determines the backend in use.
Benjamin Otte [Thu, 2 May 2013 14:06:21 +0000 (16:06 +0200)]
displaymanager: Copy logic to display creation
Use the same logic for display creation in
gdk_display_manager_open_display() that is used for displaymanager
creation.
Benjamin Otte [Thu, 2 May 2013 13:43:09 +0000 (15:43 +0200)]
quartz: Move initialization code to display_class_init
This follows the same reasoning as the X11 backend in commit
0122a9da8eab518652553aa4e777d5caf18a6163
Benjamin Otte [Thu, 2 May 2013 13:36:41 +0000 (15:36 +0200)]
win32: Call windowing init from display_class_init()
This follows the same reasoning as the X11 backend in commit
0122a9da8eab518652553aa4e777d5caf18a6163
Benjamin Otte [Thu, 2 May 2013 13:26:33 +0000 (15:26 +0200)]
a11y: Remove AtkSelection implementation from combobox
AtkSelection requires that the immediate children of the object are the
selectable items. The combobox however is implemented with just 1 child:
The popup menu.
The popup menu is implementing the selectable interface.
Test are updated to reflect this change.
Matthias Clasen [Thu, 2 May 2013 13:29:35 +0000 (09:29 -0400)]
Try this again
When the hostnamed call is cancelled, we get a G_IO_ERROR_CANCELLED
error back. Handle it properly.
Matthias Clasen [Thu, 2 May 2013 12:21:42 +0000 (08:21 -0400)]
Revert "Remove a superfluous ref"
This reverts commit
f326c0eac806b037c7100309887ffc5f9193070d.
Grr, turns out that cancelling is not that reliable :-(
Matthias Clasen [Thu, 2 May 2013 12:02:40 +0000 (08:02 -0400)]
Clear list of attached windows when disposing a widget
We were silently relying on everybody to detach their windows,
and would leak memory otherwise.
Matthias Clasen [Thu, 2 May 2013 12:01:14 +0000 (08:01 -0400)]
GtkWindow: use a weak ref to keep track of attach_widget
Taking a full reference of the attach widget creates a reference
cycle, and keeps the attach_widget alive longer than it should.
Matthias Clasen [Thu, 2 May 2013 09:53:40 +0000 (05:53 -0400)]
Remove a superfluous ref
If we cancel the call in dispose, no need to ref the object
we pass as userdata. Avoids the risk of leaking the ref if
the call is actually canceled.
Matthias Clasen [Thu, 2 May 2013 09:37:58 +0000 (05:37 -0400)]
Fix build
Matthias Clasen [Thu, 2 May 2013 02:23:11 +0000 (22:23 -0400)]
Revert "Temporarily remove window-border reftest"
This reverts commit
cf6695088e1fe98acdd2ac2e3b5c2f0dd4e7cc5b.
Matthias Clasen [Thu, 2 May 2013 02:22:22 +0000 (22:22 -0400)]
Revert "Disable the filechooser template tests"
This reverts commit
17b9733372f763805b50165f945eee65517c8f06.
Matthias Clasen [Thu, 2 May 2013 02:22:09 +0000 (22:22 -0400)]
Revert "Disable the object-finalize test for now"
This reverts commit
a021dc793c163fd427c28d13f49dbf7933d38a46.
Matthias Clasen [Thu, 2 May 2013 02:20:58 +0000 (22:20 -0400)]
Reenable display manager tests
Still broken, but they test the right thing.
Matthias Clasen [Thu, 2 May 2013 02:06:46 +0000 (22:06 -0400)]
Bump version
Matthias Clasen [Thu, 2 May 2013 01:43:19 +0000 (21:43 -0400)]
Remove window-border tests from makefile too
Matthias Clasen [Thu, 2 May 2013 01:35:39 +0000 (21:35 -0400)]
Silence a compiler warning
Matthias Clasen [Thu, 2 May 2013 01:31:12 +0000 (21:31 -0400)]
Revert "Temporarily remove button-wrapping reftest"
This reverts commit
851b631c4e8919530a49346118027a2acdf0a1b8.
Matthias Clasen [Thu, 2 May 2013 01:27:25 +0000 (21:27 -0400)]
Fix up doc sections
Matthias Clasen [Thu, 2 May 2013 01:27:06 +0000 (21:27 -0400)]
Minor doc comment fix
Matthias Clasen [Thu, 2 May 2013 01:23:55 +0000 (21:23 -0400)]
Make gtkplacessidebar.h look like a gtk header
Matthias Clasen [Thu, 2 May 2013 01:19:37 +0000 (21:19 -0400)]
GtkPlacesSidebar: Correct all since tags
Matthias Clasen [Thu, 2 May 2013 01:03:55 +0000 (21:03 -0400)]
Disable broken picker a11y test
The GtkComboBox accessible implementation is pretty broken,
and it shows through in this a11y test. Disable it for now.
Matthias Clasen [Wed, 1 May 2013 22:53:30 +0000 (18:53 -0400)]
Update a few a11y test results
Matthias Clasen [Wed, 1 May 2013 21:03:48 +0000 (17:03 -0400)]
Fix image-load-from-file reftest
Need to reset css here to avoid theme interference.
Matthias Clasen [Wed, 1 May 2013 20:55:12 +0000 (16:55 -0400)]
Temporarily remove grid-span reftest
This was testing grid size allocation changes that had to be
reverted because they broke gnumeric.
Matthias Clasen [Wed, 1 May 2013 20:51:45 +0000 (16:51 -0400)]
Temporarily remove window-border reftest
It is broken by unfinished csd changes.
Matthias Clasen [Wed, 1 May 2013 20:50:59 +0000 (16:50 -0400)]
Temporarily remove button-wrapping reftest
Its broken by unsettled GtkBin size allocation changes.
Piotr Drąg [Wed, 1 May 2013 21:48:33 +0000 (23:48 +0200)]
Updated POTFILES.skip
Benjamin Otte [Wed, 1 May 2013 21:26:27 +0000 (23:26 +0200)]
paned: Fixup recent commit
d90e3670cef44c688763f15d5695f84ebe985855 had a bunch of embarrassing
bugs.
Fixes paned-undersized reftest.
Benjamin Otte [Wed, 1 May 2013 16:12:38 +0000 (18:12 +0200)]
wayland: Don't add/remove displays manually
This code is handled by GdkDisplay itself these days.
Benjamin Otte [Wed, 1 May 2013 16:11:26 +0000 (18:11 +0200)]
x11: Move initialization code
Move it from GdkDisplayManagerX11.init to GdkDisplay.class_init.
This shouldn't cause any problems, but who knows, so keep this patch
small.
Reason for this is the unification of display managers.
Benjamin Otte [Wed, 1 May 2013 15:50:14 +0000 (17:50 +0200)]
tests: make deprecated functions not warn
We still want to test them though.
Benjamin Otte [Wed, 1 May 2013 15:46:50 +0000 (17:46 +0200)]
tests: Comment out unused functions
Benjamin Otte [Wed, 1 May 2013 14:40:13 +0000 (16:40 +0200)]
window: last size is more important than default size
reorder size computation code to reflect that.
https://bugzilla.gnome.org/show_bug.cgi?id=696882
Benjamin Otte [Wed, 1 May 2013 14:23:17 +0000 (16:23 +0200)]
window: Deprecate gtk_window_reshow_with_initial_size()
Benjamin Otte [Mon, 29 Apr 2013 23:58:59 +0000 (01:58 +0200)]
paned: Correctly compute child sizes in size requests
Benjamin Otte [Mon, 29 Apr 2013 23:15:01 +0000 (01:15 +0200)]
gtkprivate: #define OPPOSITE_ORIENTATION
and use it
Benjamin Otte [Mon, 29 Apr 2013 17:02:28 +0000 (19:02 +0200)]
paned: Split size request code
The code is pretty different for both cases, so better split things
here.
Benjamin Otte [Mon, 29 Apr 2013 16:20:22 +0000 (18:20 +0200)]
paned: Split out a function
Benjamin Otte [Mon, 29 Apr 2013 13:07:22 +0000 (15:07 +0200)]
button: Rework size request/allocation code
- Split out a common function
- Implement hfw properly.
Benjamin Otte [Mon, 29 Apr 2013 13:07:01 +0000 (15:07 +0200)]
widget: Improve debug output
Benjamin Otte [Sat, 27 Apr 2013 21:24:41 +0000 (23:24 +0200)]
button: Use _gtk_widget_get_preferred_size_for_size()
This was accidently lost when merging baseline support.
Benjamin Otte [Sat, 27 Apr 2013 21:16:11 +0000 (23:16 +0200)]
widget: Adapt _gtk_widget_get_preferred_size_for_size()
... for baseline support byu taking two extra (possible NULL) arguments.
Benjamin Otte [Sat, 27 Apr 2013 21:13:03 +0000 (23:13 +0200)]
tests: Add reftest for broken button sizing
https://bugzilla.gnome.org/show_bug.cgi?id=698433
Matthias Clasen [Wed, 1 May 2013 14:28:53 +0000 (10:28 -0400)]
Disable the filechooser template tests
The places sidebar breaks the finalization checks in these tests
https://bugzilla.gnome.org/show_bug.cgi?id=699393
Matthias Clasen [Wed, 1 May 2013 14:28:03 +0000 (10:28 -0400)]
Disable the object-finalize test for now
GtkPlacesSidebar breaks this:
https://bugzilla.gnome.org/show_bug.cgi?id=699393
Matthias Clasen [Wed, 1 May 2013 14:27:37 +0000 (10:27 -0400)]
Add missing symbols
Matthias Clasen [Wed, 1 May 2013 13:41:11 +0000 (09:41 -0400)]
Comment out broken tests
Tsk, tsk. These tests were broken in the recent display manager
changes. Please run make check after major refactoring.
Matthias Clasen [Wed, 1 May 2013 12:46:50 +0000 (08:46 -0400)]
Avoid an accidental export
Matthias Clasen [Wed, 1 May 2013 12:29:01 +0000 (08:29 -0400)]
Updates
Hib Eris [Tue, 30 Apr 2013 14:17:43 +0000 (16:17 +0200)]
Revert "Don't build gtk-launch when gio-unix is not available"
The gtk-launch tool can be build without gio-unix (although it
will not really do much without an alternative implementation for
g_desktop_app_info).
So there is no need to not build gtk-launch anymore.
This reverts commit
9a1235bf0dbdb1701779bec0ccae043cc4243ce5.
https://bugzilla.gnome.org/show_bug.cgi?id=682824
Milo Casagrande [Tue, 30 Apr 2013 17:22:12 +0000 (19:22 +0200)]
[l10n] Updated Italian translation.
Milo Casagrande [Mon, 29 Apr 2013 21:00:27 +0000 (23:00 +0200)]
[l10n] Updated Italian translation.
Matthias Clasen [Mon, 29 Apr 2013 17:06:59 +0000 (13:06 -0400)]
Fix a typo
Modifed should be Modified.
https://bugzilla.gnome.org/show_bug.cgi?id=699225
Alexander Larsson [Mon, 29 Apr 2013 16:15:12 +0000 (18:15 +0200)]
gtksizerequestcache: Fix typo that lead to crash/leak
We were checking for cache->requests_x but freeing cache->requests_y
which could cause a crash/leak.
David King [Tue, 13 Nov 2012 14:13:32 +0000 (14:13 +0000)]
docs: Reorder compiler command line for new GCC
Newer versions of GCC/binutils must have the source file come before the
preprocessor and linker flags on the compiler command line, and this is
also compatible with previous versions.
https://bugzilla.gnome.org/show_bug.cgi?id=680241
David King [Thu, 22 Nov 2012 20:33:13 +0000 (20:33 +0000)]
docs: Add GtkWidget::show,hide,map,unmap,realize,unrealize
Add gtk-doc comments for several signals on GtkWidget.
https://bugzilla.gnome.org/show_bug.cgi?id=688896
David King [Thu, 15 Nov 2012 18:54:47 +0000 (18:54 +0000)]
docs: Add (inout) to requisition of gtk_menu_item_toggle_size_request()
https://bugzilla.gnome.org/show_bug.cgi?id=675571
Matthias Clasen [Mon, 29 Apr 2013 01:43:49 +0000 (21:43 -0400)]
Fix a few memory leaks wrt to translations
Pointed out in https://bugzilla.gnome.org/show_bug.cgi?id=699016
The fix here is slightly different. We make
_gtk_builder_parser_translate return a const char * instead of
a dup'ed string, and fix up the callers.
Matthias Clasen [Sun, 28 Apr 2013 22:46:41 +0000 (18:46 -0400)]
GtkGrid: Undo a size allocation tweak
Revert
5e1a06d1b124f09a1a54d5ae0f38905dbdc2cc81
This change caused empty rows to 'open up', which was not
intended and causes problems as seen in bug 698660.
Matthias Clasen [Sun, 28 Apr 2013 22:46:11 +0000 (18:46 -0400)]
Add a testcase for empty grid rows
This adds a testcase described in bug 698660 to testgrid.
Žygimantas Beručka [Sun, 28 Apr 2013 10:24:23 +0000 (13:24 +0300)]
Updated Lithuanian translation